Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide time series + xgboost demos by default #2079

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

freddyaboulton
Copy link
Collaborator

@freddyaboulton freddyaboulton commented Aug 24, 2022

Description

Fix a mistake I made in #2067 where I didn't hide the new demos by default

Checklist:

  • I have performed a self-review of my own code
  • My code follows the style guidelines of this project
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@freddyaboulton freddyaboulton marked this pull request as ready for review August 24, 2022 17:59
@aliabd
Copy link
Collaborator

aliabd commented Aug 24, 2022

The link for the source on time series forecasting is broken, missing the /spaces/.

Also I would recommend adding a code block like the original demos, and linking to the code there instead, something like below, but definitely not a big deal.
Screen Shot 2022-08-24 at 11 14 57 AM

@freddyaboulton
Copy link
Collaborator Author

freddyaboulton commented Aug 24, 2022

Thanks for pointing out the broken link @aliabd 🙈 ! Will fix in the space + make the other changes we discussed offline (replacing source with code and linking to the code itself)

@freddyaboulton freddyaboulton merged commit dc437f4 into main Aug 24, 2022
@freddyaboulton freddyaboulton deleted the hide-new-demos-on-landing-page branch August 24, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants