Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ColorPicker to docs #1768

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Add ColorPicker to docs #1768

merged 1 commit into from
Jul 18, 2022

Conversation

freddyaboulton
Copy link
Collaborator

@freddyaboulton freddyaboulton commented Jul 12, 2022

Description

Fixes #1743

Checklist:

  • I have performed a self-review of my own code
  • My code follows the style guidelines of this project
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@@ -0,0 +1 @@
Pillow
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the color picker demos is properly built on the website demos

Screen Shot 2022-07-12 at 12 40 32 PM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this requirements file, when pillow is a dependency of gradio?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this requirements file, when pillow is a dependency of gradio?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in case gradio changes its dependencies.

interactive (Optional[bool]): if True, will be rendered as an editable color picker; if False, editing will be disabled. If not provided, this is inferred based on whether the component is used as an input or output.
visible (bool): If False, component will be hidden.
elem_id (Optional[str]): An optional string that is assigned as the id of this component in the HTML DOM. Can be used for targeting CSS styles.
value: default text to provide in color picker.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor tweaks here to conform to the docstring format

@freddyaboulton freddyaboulton marked this pull request as ready for review July 12, 2022 16:42
@abidlabs
Copy link
Member

LGTM, just wondering about the requiements.txt file

@aliabid94
Copy link
Collaborator

LGTM

@omerXfaruq omerXfaruq merged commit 0063474 into main Jul 18, 2022
@omerXfaruq omerXfaruq deleted the 1743-add-color-picker-to-docs branch July 18, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ColorPicker component does not appear in documentation
4 participants