added better default labels to form components #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pngwn
approved these changes
Apr 20, 2022
|
Yay thanks @pngwn! |
omerXfaruq
reviewed
Apr 21, 2022
| @@ -4,7 +4,7 @@ | |||
| export let value: boolean = false; | |||
| export let default_value: boolean = false; | |||
| export let style: string = ""; | |||
| export let label: string; | |||
There was a problem hiding this comment.
Question: How does the label is realized when the user provides one?
There was a problem hiding this comment.
@pngwn the default label is assigned like this:
export let label: string = "Checkbox";
I was wondering how do we assign the label given by the user
There was a problem hiding this comment.
These export let statement essentially marks the interface for the component. They are passed in from above : <Checkbox label="some_label" />. Same way arguments are marked on a function and passed in by the caller.
| @@ -164,5 +165,24 @@ def test_format_ner_list_empty(self): | |||
| self.assertEqual(format_ner_list(string, groups), result) | |||
|
|
|||
|
|
|||
| class TestDeleteNone(unittest.TestCase): | |||
There was a problem hiding this comment.
Good practice to write a test for it, great!
| @@ -2371,7 +2369,11 @@ def get_template_context(self): | |||
| return {"default_value": self.default_value, **super().get_template_context()} | |||
|
|
|||
|
|
|||
| ############################ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds better default labels to form components. Instead of "null", the label now shows the name of the component. For example, the default label for a slider is "Slider":
Of course, these labels can be overridden by the user to say whatever they want. In the
Interfaceclass, the labels continue to be based off of the parameter names (for the input components) and are "output" or "output X" for the output components.As part of this work, I also removed any prop whose value is "null" from the config. This could potentially lead to some problems, so it would be great if you could review this @pngwn. For example, I noticed that the
interactiveprop could taketrue,false, ornull, and so I adapted the logic to not depend onnull.Also I included some other minor cleanups that I noticed going through the components.py file.
Closes: #669 #982