Add optional z-lift on travel move. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmeess
commented
Oct 12, 2018
| Builder.AppendExtrude(loopV, useSpeed, poly.TypeFlags, null); | ||
| } | ||
|
|
||
| private void AppendTravel(Vector2d startPt, Vector2d endPt) |
There was a problem hiding this comment.
Broke out into new method:
- original logic for whether or not to retract
- new logic for whether or not to do a z-lift before moving
gregmeess
commented
Oct 12, 2018
| @@ -112,7 +133,7 @@ public virtual void AppendPolyline2d(FillPolyline2d curve) | |||
| } | |||
|
|
|||
| Vector2d startPt = curve[iNearest]; | |||
| Builder.AppendTravel(startPt, Settings.RapidTravelSpeed); | |||
| AppendTravel(currentPos2, startPt); | |||
There was a problem hiding this comment.
Previously there was no check here for whether or not do to a travel with retraction; now this uses the logic in the new method. Not sure if a possible "leaky move" is desired here or not.
gregmeess
pushed a commit
to SutroMachine/gsSlicer
that referenced
this pull request
Feb 26, 2020
Make the position of the build plate origin a user-accessible setting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.