Skip to content

Add regression tests for Windows args-file paths#915

Merged
jormundur00 merged 1 commit into
graalvm:masterfrom
jormundur00:rhei/issue-754
Jul 4, 2026
Merged

Add regression tests for Windows args-file paths#915
jormundur00 merged 1 commit into
graalvm:masterfrom
jormundur00:rhei/issue-754

Conversation

@jormundur00

@jormundur00 jormundur00 commented Jun 8, 2026

Copy link
Copy Markdown
Member

Fixes #754

What changed

This PR adds regression coverage for Windows args-file path handling in the shared common utilities.

Before this change, the implementation already aimed to avoid relativizing paths across different Windows roots, but there was no focused regression coverage proving that behavior.

After this change, the shared args-file conversion logic is covered by Windows-root regression tests for both same-root and cross-root cases.

Why

Path handling bugs at this layer affect both Gradle and Maven native-image invocation. Adding regression coverage here protects shared behavior without relying on a Windows machine or a full product-level reproduction.

Example

Before:

A Windows args-file path on the same drive and one on a different drive were both handled by the same shared utility path logic, but only manual reasoning or ad hoc testing could confirm whether the cross-root case stayed absolute.

After:

The shared utility now has Jimfs-backed Windows regression coverage verifying that same-root paths can be relativized while cross-root paths remain absolute.

Implementation summary

  • Keep NativeImageUtils.convertToArgsFile on Path and Files APIs so it can be exercised with alternate file-system providers.
  • Add Jimfs-backed Windows filesystem tests covering same-root relative args-file paths and cross-root absolute args-file paths.
  • Add Jimfs as a test-only dependency for the common utilities module.

Validation

  • grund check
  • grund fmt . --marker --check
  • git diff --check
  • JAVA_HOME=$HOME/.sdkman/candidates/java/17.0.12-graal ./gradlew :utils:test --tests org.graalvm.buildtools.utils.NativeImageUtilsTest --rerun-tasks
  • JAVA_HOME=$HOME/.sdkman/candidates/java/17.0.12-graal ./gradlew :native-gradle-plugin:test :native-gradle-plugin:inspections

@oracle-contributor-agreement oracle-contributor-agreement Bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 8, 2026
@jormundur00
jormundur00 marked this pull request as ready for review July 2, 2026 10:48
@jormundur00
jormundur00 merged commit 6a4139f into graalvm:master Jul 4, 2026
50 checks passed
mergify Bot added a commit to robfrank/linklift that referenced this pull request Jul 17, 2026
….2 to 1.1.4 [skip ci]

Bumps [org.graalvm.buildtools:native-maven-plugin](https://github.com/graalvm/native-build-tools) from 1.1.2 to 1.1.4.
Release notes

*Sourced from [org.graalvm.buildtools:native-maven-plugin's releases](https://github.com/graalvm/native-build-tools/releases).*

> 1.1.4
> -----
>
> What's Changed
> --------------
>
> * Release 1.1.3 by [`@​graalvmbot`](https://github.com/graalvmbot) in [graalvm/native-build-tools#944](https://redirect.github.com/graalvm/native-build-tools/pull/944)
> * Bump version to 1.1.4-SNAPSHOT by [`@​graalvmbot`](https://github.com/graalvmbot) in [graalvm/native-build-tools#946](https://redirect.github.com/graalvm/native-build-tools/pull/946)
> * Re-enable layered application functional test by [`@​jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#904](https://redirect.github.com/graalvm/native-build-tools/pull/904)
> * Fix Gradle system property quoting by [`@​jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#907](https://redirect.github.com/graalvm/native-build-tools/pull/907)
> * Avoid disabled agent instrumentation by [`@​jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#905](https://redirect.github.com/graalvm/native-build-tools/pull/905)
> * Use systemPropertyVariables for Maven test plugin injection by [`@​jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#902](https://redirect.github.com/graalvm/native-build-tools/pull/902)
> * Improve missing metadata reporting for newer repository releases by [`@​jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#948](https://redirect.github.com/graalvm/native-build-tools/pull/948)
> * Fix invalid Gradle tracing-agent grund citation by [`@​jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#950](https://redirect.github.com/graalvm/native-build-tools/pull/950)
> * Use explicit Gradle project dependency notation and test on Gradle 9.6.1 by [`@​jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#903](https://redirect.github.com/graalvm/native-build-tools/pull/903)
> * Migrate functional CI to GraalVM for JDK 25 by [`@​jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#953](https://redirect.github.com/graalvm/native-build-tools/pull/953)
> * Add Maven plugin inspections to CI by [`@​jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#911](https://redirect.github.com/graalvm/native-build-tools/pull/911)
> * Add common utils CI gate by [`@​jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#912](https://redirect.github.com/graalvm/native-build-tools/pull/912)
> * Fix Maven metadata repository fallback mutation by [`@​jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#914](https://redirect.github.com/graalvm/native-build-tools/pull/914)
> * Add regression tests for Windows args-file paths by [`@​jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#915](https://redirect.github.com/graalvm/native-build-tools/pull/915)
> * Update reachability metadata to 1.0.5 by [`@​graalvmbot`](https://github.com/graalvmbot) in [graalvm/native-build-tools#962](https://redirect.github.com/graalvm/native-build-tools/pull/962)
>
> **Full Changelog**: <graalvm/native-build-tools@1.1.3...1.1.4>
>
> 1.1.3
> -----
>
> What's Changed
> --------------
>
> * Release 1.1.2 by [`@​graalvmbot`](https://github.com/graalvmbot) in [graalvm/native-build-tools#923](https://redirect.github.com/graalvm/native-build-tools/pull/923)
> * Bump version to 1.1.3-SNAPSHOT by [`@​graalvmbot`](https://github.com/graalvmbot) in [graalvm/native-build-tools#924](https://redirect.github.com/graalvm/native-build-tools/pull/924)
> * Bump io.netty:netty-codec-http from 4.1.132.Final to 4.1.135.Final in /samples/metadata-repo-integration by [`@​dependabot`](https://github.com/dependabot)[bot] in [graalvm/native-build-tools#932](https://redirect.github.com/graalvm/native-build-tools/pull/932)
> * Refine grund specification by [`@​jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#917](https://redirect.github.com/graalvm/native-build-tools/pull/917)
>
> **Full Changelog**: <graalvm/native-build-tools@1.1.2...1.1.3>


Commits

* [`68c8e9f`](graalvm/native-build-tools@68c8e9f) Release 1.1.4
* [`a38531d`](graalvm/native-build-tools@a38531d) Merge pull request [#962](https://redirect.github.com/graalvm/native-build-tools/issues/962) from graalvm/update-metadata-to-1.0.5
* [`3073b19`](graalvm/native-build-tools@3073b19) Update reachability metadata to 1.0.5
* [`6a4139f`](graalvm/native-build-tools@6a4139f) Add regression tests for Windows args-file paths ([#915](https://redirect.github.com/graalvm/native-build-tools/issues/915))
* [`128dd2c`](graalvm/native-build-tools@128dd2c) Fix Maven metadata repository fallback mutation ([#914](https://redirect.github.com/graalvm/native-build-tools/issues/914))
* [`12ebca4`](graalvm/native-build-tools@12ebca4) Add common utils CI gate ([#912](https://redirect.github.com/graalvm/native-build-tools/issues/912))
* [`609bc14`](graalvm/native-build-tools@609bc14) Add Maven plugin inspections to CI ([#911](https://redirect.github.com/graalvm/native-build-tools/issues/911))
* [`52a30b1`](graalvm/native-build-tools@52a30b1) Migrate functional CI to GraalVM for JDK 25 ([#953](https://redirect.github.com/graalvm/native-build-tools/issues/953))
* [`4bdb360`](graalvm/native-build-tools@4bdb360) Use explicit Gradle project dependency notation and test on Gradle 9.6.1 ([#903](https://redirect.github.com/graalvm/native-build-tools/issues/903))
* [`fb710bb`](graalvm/native-build-tools@fb710bb) Fix invalid Gradle tracing-agent grund citation ([#950](https://redirect.github.com/graalvm/native-build-tools/issues/950))
* Additional commits viewable in [compare view](graalvm/native-build-tools@1.1.2...1.1.4)
  
[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=org.graalvm.buildtools:native-maven-plugin&package-manager=maven&previous-version=1.1.2&new-version=1.1.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement. rhei

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Native Image] Error > 'other' has different root when building

2 participants