Skip to content

Conversation

@dnestoro
Copy link
Contributor

@dnestoro dnestoro commented Jun 9, 2025

In order to execute integration tests with Native Build Tools Maven plugin, we should support Maven failsafe plugin. Previously this only worked because we had fallback mode for JUnit tests which unintentionally discovered integration tests as well. Since we removed that fallback mode, we have to support integration tests properly.

This PR adds JUnit listeners configuration when using Maven failsafe plugin and collect environmentVariables and systemPropertyVariables provided through it.

@dnestoro dnestoro requested a review from alvarosanchez June 9, 2025 13:28
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 9, 2025
@dnestoro dnestoro force-pushed the dnestoro/add-support-for-failsafe-plugin branch from b99d2b1 to c2fa6f4 Compare June 9, 2025 21:57
@dnestoro dnestoro force-pushed the dnestoro/add-support-for-failsafe-plugin branch from c2fa6f4 to 478d775 Compare June 9, 2025 22:00
@dnestoro dnestoro requested a review from melix June 9, 2025 22:11
@dnestoro dnestoro changed the title Add support for integration tests through Maven Add support for running integration tests with Maven Jun 9, 2025
melix
melix previously approved these changes Jun 10, 2025
Copy link
Contributor

@marcphilipp marcphilipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dnestoro dnestoro force-pushed the dnestoro/add-support-for-failsafe-plugin branch from dbe4e64 to f378212 Compare June 19, 2025 08:16
@dnestoro dnestoro merged commit ad0e84c into master Jun 19, 2025
187 checks passed
@dnestoro dnestoro deleted the dnestoro/add-support-for-failsafe-plugin branch June 19, 2025 13:31
@dnestoro dnestoro self-assigned this Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants