Skip to content

Conversation

@hogoww
Copy link

@hogoww hogoww commented Jan 29, 2025

Hello,

I'm reading a bunch of documentation and found a few mistakes.
The committed one was a fairly easy fix, but others are not.
I'd love to do more, but I'll need some support for that !

Here are the other ones I found so far:
https://github.com/graalvm/native-build-tools/blob/master/docs/src/docs/asciidoc/maven-plugin.adoc

  • There's another gradle reference at the start of the file :highlighjsdir: {gradle-relative-srcdir}/highlight that doesn't seem to render. I don't know this syntax.
  • The javadoc link at the end of the file is broken.

The snippet in those two files seems reversed.

I have signed the OCA a couple of years ago, seems to never have been fvalidated.
I did it again yesterday.

Have a nice day !

@oracle-contributor-agreement
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Jan 29, 2025
@dnestoro dnestoro requested a review from olyagpl January 29, 2025 13:33
@oracle-contributor-agreement
Copy link

Thank you for signing the OCA.

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Jan 30, 2025
@dnestoro dnestoro merged commit 8c08154 into graalvm:master Mar 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants