Introduce and migrate to a plugin configuration mechanism. #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
lazar-mitrovic
approved these changes
Jun 18, 2021
gradinac
force-pushed
the
gradinac/plugin-config-mechanism
branch
3 times, most recently
from
a9b4f31 to
d5d9fc8
Compare
2 tasks
gradinac
force-pushed
the
gradinac/plugin-config-mechanism
branch
from
d5d9fc8 to
396f409
Compare
gradinac
commented
Jun 23, 2021
...m-native/src/main/java/org/graalvm/junit/platform/UniqueIdTrackingTestExecutionListener.java
Show resolved
Hide resolved
gradinac
force-pushed
the
gradinac/plugin-config-mechanism
branch
from
396f409 to
f29a82d
Compare
sbrannen
requested changes
Jun 25, 2021
Collaborator
sbrannen
left a comment
sbrannen
left a comment
There was a problem hiding this comment.
This PR is certainly improving a lot!
I've added several questions and suggestions.
...orm-native/src/main/java/org/graalvm/junit/platform/config/NativeImageConfigurationImpl.java
Outdated
Show resolved
Hide resolved
...orm-native/src/main/java/org/graalvm/junit/platform/config/NativeImageConfigurationImpl.java
Outdated
Show resolved
Hide resolved
...rm-native/src/main/java/org/graalvm/junit/platform/config/core/NativeImageConfiguration.java
Outdated
Show resolved
Hide resolved
...rm-native/src/main/java/org/graalvm/junit/platform/config/core/NativeImageConfiguration.java
Outdated
Show resolved
Hide resolved
...rm-native/src/main/java/org/graalvm/junit/platform/config/core/NativeImageConfiguration.java
Outdated
Show resolved
Hide resolved
...rm-native/src/main/java/org/graalvm/junit/platform/config/vintage/VintageConfigProvider.java
Show resolved
Hide resolved
...rm-native/src/main/java/org/graalvm/junit/platform/config/vintage/VintageConfigProvider.java
Show resolved
Hide resolved
common/junit-platform-native/src/test/java/org/graalvm/junit/jupiter/TestMethodOrderTests.java
Show resolved
Hide resolved
common/junit-platform-native/src/test/java/org/graalvm/junit/jupiter/TestMethodOrderTests.java
Outdated
Show resolved
Hide resolved
common/junit-platform-native/src/test/java/org/graalvm/junit/util/Calculator.java
Outdated
Show resolved
Hide resolved
sbrannen
approved these changes
Jun 28, 2021
gradinac
force-pushed
the
gradinac/plugin-config-mechanism
branch
2 times, most recently
from
d4fa225 to
675f9e8
Compare
gradinac
force-pushed
the
gradinac/plugin-config-mechanism
branch
from
675f9e8 to
9971efb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a plugin configuration mechanism to separate plugin configuration from the JUnit feature. The core of this mechanism is the
PluginConfigProviderservice. The service currently implements 2 callbacks:JUnitPlatformFeatureis loadedThe provider receives a
NativeImageConfigurationobject that allows registering classes for reflection and build time initialization, removing the dependency to Native Image classes.Currently, three such providers are implemented:
All plugin-specific configuration has been moved from the feature to their respective provider.
Closes #54
Closes #51
Closes #50