Add a sharedLibrary configuration option for Gradle plugin
#121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazar-mitrovic
added
enhancement
lazar-mitrovic
force-pushed
the
gradle-shared-library
branch
from
2e0dd49 to
9a46f0a
Compare
melix
approved these changes
Aug 12, 2021
Collaborator
melix
left a comment
melix
left a comment
There was a problem hiding this comment.
I left a couple comments which would be great to fix, no blockers. And since you wrote a pom.xml file for the sample, would actually be good to add a test for Maven too.
native-gradle-plugin/src/main/java/org/graalvm/buildtools/gradle/NativeImagePlugin.java
Show resolved
Hide resolved
...gin/src/functionalTest/groovy/org/graalvm/buildtools/gradle/JavaLibraryFunctionalTest.groovy
Show resolved
Hide resolved
lazar-mitrovic
force-pushed
the
gradle-shared-library
branch
4 times, most recently
from
a7d294e to
43d7f8d
Compare
This commit adds `sharedLibrary` configuration option to the Gradle plugin as it was a requested feature. `java-library` test sample is also included as well as corresponding functional test.
lazar-mitrovic
force-pushed
the
gradle-shared-library
branch
from
43d7f8d to
29313e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds
sharedLibraryconfiguration option to the Gradle plugin as it was a requested feature (closes #119).java-librarytest sample is also included as well as corresponding functional test.