[GR-48667] Look for AddExports in Suite.SuiteClasses

PullRequest: mx/1677
graalvm · Sep 15, 2023 · f0c8c7c · f0c8c7c
2 parents aa775d2 + 2739de2
commit f0c8c7c
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 2 deletions.
diff --git a/java/com.oracle.mxtool.junit.jdk9/src/com/oracle/mxtool/junit/ModuleSupport.java b/java/com.oracle.mxtool.junit.jdk9/src/com/oracle/mxtool/junit/ModuleSupport.java
@@ -35,6 +35,8 @@
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
+import org.junit.runners.Suite;
+
 import jdk.internal.module.Modules;
 
 class ModuleSupport {
@@ -45,7 +47,13 @@ class ModuleSupport {
         this.out = out;
     }
 
-    void processAddExportsAnnotations(Set<Class<?>> classes, Set<String> opened, Set<String> exported) {
+    void processAddExportsAnnotations(Set<Class<?>> requestClasses, Set<String> opened, Set<String> exported) {
+        Set<Class<?>> classes = new HashSet<>();
+
+        for (Class<?> cls : requestClasses) {
+            gatherClasses(cls, classes);
+        }
+
         Set<Class<?>> types = new HashSet<>();
         for (Class<?> cls : classes) {
             gatherSupertypes(cls, types);
@@ -68,6 +76,22 @@ void processAddExportsAnnotations(Set<Class<?>> classes, Set<String> opened, Set
         }
     }
 
+    /**
+     * Recursively looks through the given base class for {@code Suite.SuiteClasses} annotations and
+     * adds all classes to the set.
+     */
+    private void gatherClasses(Class<?> base, Set<Class<?>> classes) {
+        if (!classes.contains(base)) {
+            classes.add(base);
+            Suite.SuiteClasses annot = base.getDeclaredAnnotation(Suite.SuiteClasses.class);
+            if (annot != null) {
+                for (Class<?> cls : annot.value()) {
+                    gatherClasses(cls, classes);
+                }
+            }
+        }
+    }
+
     void processAddModulesAnnotations(Set<Class<?>> classes) {
         Set<Class<?>> types = new HashSet<>();
         for (Class<?> cls : classes) {

diff --git a/mx.mx/suite.py b/mx.mx/suite.py
@@ -880,6 +880,9 @@
     "com.oracle.mxtool.junit.jdk9" : {
       "subDir" : "java",
       "sourceDirs" : ["src"],
+      "dependencies" : [
+        "JUNIT",
+      ],
       "requiresConcealed" : {
         "java.base" : [
           "jdk.internal.module",

diff --git a/mx.py b/mx.py
@@ -18789,7 +18789,7 @@ def alarm_handler(signum, frame):
         abort(1, killsig=signal.SIGINT)
 
 # The version must be updated for every PR (checked in CI) and the comment should reflect the PR's issue
-version = VersionSpec("6.49.1")  # fetch-jdk labsjdk-ee-latest
+version = VersionSpec("6.50.0")  # GR-48667 Scan SuiteClasses for @AddExports
 
 _mx_start_datetime = datetime.utcnow()
 _last_timestamp = _mx_start_datetime