Skip to content

Commit

Permalink
[GR-58295] Treat foreign = True as ignore_suite_commit = True in …
Browse files Browse the repository at this point in the history
…mx benchmarks

PullRequest: mx/1842
  • Loading branch information
liufengyun committed Oct 10, 2024
2 parents de145ef + 19b545f commit 0823db9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/mx/_impl/mx.py
Original file line number Diff line number Diff line change
Expand Up @@ -18204,7 +18204,7 @@ def alarm_handler(signum, frame):
_CACHE_DIR = get_env('MX_CACHE_DIR', join(dot_mx_dir(), 'cache'))

# The version must be updated for every PR (checked in CI) and the comment should reflect the PR's issue
version = VersionSpec("7.32.3") # [GR-58959] Fix the detection of Truffle language launchers in proftool
version = VersionSpec("7.32.4") # [GR-58295] Ignore commit info for foreign suites in mx benchmarks

_mx_start_datetime = datetime.utcnow()

Expand Down
2 changes: 1 addition & 1 deletion src/mx/_impl/mx_benchmark.py
Original file line number Diff line number Diff line change
Expand Up @@ -3426,7 +3426,7 @@ def commit_info(prefix, mxsuite):
standard.update(commit_info("", mx.primary_suite()))
for mxsuite in mx.suites():
ignored = mxBenchmarkArgs.ignore_suite_commit_info
if (ignored and mxsuite.name in ignored) or mxsuite.ignore_suite_commit_info:
if (ignored and mxsuite.name in ignored) or mxsuite.ignore_suite_commit_info or mxsuite.foreign:
continue
standard.update(commit_info(mxsuite.name + ".", mxsuite))
triggering_suite = self.triggeringSuite(mxBenchmarkArgs)
Expand Down

0 comments on commit 0823db9

Please sign in to comment.