Skip to content

feat: user-defined required constructor options #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 20, 2021
Merged

feat: user-defined required constructor options #63

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4df5e57
build(test): run all code & TS tests in the root folder and all `exam…
gr2m Jul 17, 2021
e1aebc5
style: prettier
gr2m Jul 17, 2021
61036c4
feat: required-options example
gr2m Jul 17, 2021
8c777a4
Update examples/required-options/README.md
gr2m Jul 18, 2021
74bdd51
I think it's all working now
JoshuaKGoldberg Jul 18, 2021
ba85870
fix(examples/required-options): check for type of required option ins…
gr2m Jul 19, 2021
32744ac
Use undefined instead of never
JoshuaKGoldberg Jul 20, 2021
b9bfbc3
Merge branch '60-handle-user-defined-required-options' of https://git…
JoshuaKGoldberg Jul 20, 2021
2ec3e41
Remove debug property
JoshuaKGoldberg Jul 20, 2021
526b802
Update examples/required-options/index.d.ts
gr2m Jul 20, 2021
8ee38c8
Update examples/required-options/index.test-d.ts
gr2m Jul 20, 2021
5c4fdde
Update examples/required-options/README.md
gr2m Jul 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update examples/required-options/index.test-d.ts
  • Loading branch information
@gr2m
gr2m authored Jul 20, 2021
commit 8ee38c8590c09e6346d5f48cdfb1d1086d4efe93
6 changes: 6 additions & 0 deletions examples/required-options/index.test-d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,9 @@ new MyBase({});
new MyBase({
myRequiredUserOption: "",
});

const MyBaseWithDefaults = MyBase.defaults({
myRequiredUserOption: "",
});

new MyBaseWithDefaults();