test: plugin function with empty object return

[gr2m]

Follow up for https://github.com/octokit/rest.js/pull/1625

The test passes, but the TypeScript typeahead is not workin in VS Code for me

Here is the code from the gif

import { Base } from "./src"

function plugin1 (base: Base) {
  return {
    plugin1 () {}
  }
}

function plugin2 (base: Base) {
  return {
    plugin2 () {}
  }
}

function plugin3 (base: Base) {
  return {
    // plugin3 () {}
  }
}

const Test = Base.plugin([plugin1, plugin2, plugin3])
const test = new Test()

test.p

I hope it will be easier to get to the bottom of this with this reduced test case, compared to all the baggage that Octokit brings.

Besides fixing the problem, I wonder if anyone has an idea how to add a breaking test for this case?

ping @wolfy1339

[gr2m]

Here is a TypeScript playground link with the most minimal test case I could come up with: playground link

Toggle line 63 and check the typeahead for test.pl in the last line

[gr2m]

See the workaround at octokit/core.js#53

[github-actions]

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀