Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_powerstat/set_powerstat to remote control. #1335

Closed
wants to merge 2 commits into from

Conversation

kukabu
Copy link
Contributor

@kukabu kukabu commented Feb 6, 2024

No description provided.

@argilo
Copy link
Member

argilo commented Feb 6, 2024

Did you have a look at #1334?

Responding to \get_powerstat with 0 seems to be problematic for WSJT-X, so the proposal was to always respond with 1.

Is there another program that you're trying to integrate with here?

@kukabu
Copy link
Contributor Author

kukabu commented Feb 7, 2024

Why should we add a workaround for a bug in WSJT-X?
When you run WSJT-X with poweroff radio (not GQRX) you must understand that this won't work.

It's old patch and I forgot why I wrote it. :(

@argilo
Copy link
Member

argilo commented Feb 7, 2024

Why should we add a workaround for a bug in WSJT-X?

I'm not sure it's a bug. It sounds like WSJT-X just has an annoying error dialog that appears when the rig is off.

It's also not entirely clear to me whether it makes sense to map rigctl's "power" to Gqrx's "DSP on/off". "Power" could just as well mean "Gqrx is running".

@kukabu
Copy link
Contributor Author

kukabu commented Feb 7, 2024

"Gqrx is running" is standby mode, "DSP on" is power on, imho.

@argilo
Copy link
Member

argilo commented Feb 9, 2024

Thanks for the contribution.

I'd prefer not to tie hamlib's "power" function to Gqrx's "DSP on/off", so I'm closing this off in favour of #1334.

@argilo argilo closed this Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants