Skip to content

Compat: Check that textureBindingViewDimension can not pass in cube-array #4543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
greggman wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −2
Open

Compat: Check that textureBindingViewDimension can not pass in cube-array #4543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/webgpu/compat/api/validation/texture/createTexture.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,9 @@ g.test('invalidTextureBindingViewDimension')
textureBindingViewDimension === '2d'
? 1
: 6;
const shouldError = getTextureDimensionFromView(textureBindingViewDimension) !== dimension;
const shouldError =
getTextureDimensionFromView(textureBindingViewDimension) !== dimension ||
textureBindingViewDimension === 'cube-array';
t.expectGPUErrorInCompatibilityMode(
'validation',
() => {
Expand Down
4 changes: 3 additions & 1 deletion src/webgpu/util/texture/base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,9 @@ export function virtualMipSize(
* Get texture dimension from view dimension in order to create an compatible texture for a given
* view dimension.
*/
export function getTextureDimensionFromView(viewDimension: GPUTextureViewDimension) {
export function getTextureDimensionFromView(
viewDimension: GPUTextureViewDimension
): GPUTextureDimension {
switch (viewDimension) {
case '1d':
return '1d';
Expand Down