Skip to content

maxInterStageShaderVariables: decrement max fragment input outputs per fragment input built-in #4539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ErichDonGubler merged 3 commits into from
Dec 22, 2025
Merged

maxInterStageShaderVariables: decrement max fragment input outputs per fragment input built-in #4539

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
54cedab
refactor: normalize deductions in `maxInterStageShaderVariables`' `ge…
ErichDonGubler Dec 20, 2025
8b47cfc
fix: `maxInterStageShaderVariables`: treat each fragment input built-…
ErichDonGubler Dec 20, 2025
5587128
refactor: `maxInterStageShaderVariables`: use `map`-`reduce` for frag…
ErichDonGubler Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/webgpu/api/validation/capability_checks/limits/maxInterStageShaderVariables.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,19 @@ function getPipelineDescriptor(
sampleMaskIn: boolean,
sampleMaskOut: boolean
): GPURenderPipelineDescriptor {
const vertexOutputVariables = testValue - (pointList ? 1 : 0);
const fragmentInputVariables = testValue - (frontFacing || sampleIndex || sampleMaskIn ? 1 : 0);
const vertexOutputDeductions = pointList ? 1 : 0;
const fragmentInputDeductions = [frontFacing, sampleIndex, sampleMaskIn]
.map(p => (p ? 1 : 0) as number)
.reduce((acc, p) => acc + p);

const vertexOutputVariables = testValue - vertexOutputDeductions;
const fragmentInputVariables = testValue - fragmentInputDeductions;
const numInterStageVariables = Math.min(vertexOutputVariables, fragmentInputVariables);

const maxVertexOutputVariables = device.limits.maxInterStageShaderVariables - (pointList ? 1 : 0);
const maxVertexOutputVariables =
device.limits.maxInterStageShaderVariables - vertexOutputDeductions;
const maxFragmentInputVariables =
device.limits.maxInterStageShaderVariables -
(frontFacing || sampleIndex || sampleMaskIn ? 1 : 0);
device.limits.maxInterStageShaderVariables - fragmentInputDeductions;
const maxInterStageVariables = Math.min(maxVertexOutputVariables, maxFragmentInputVariables);

const varyings = `
Expand Down