Skip to content

Conversation

@shaoboyan091
Copy link
Contributor

@shaoboyan091 shaoboyan091 commented Dec 4, 2025

This PR update gpuweb/types version to include immediate related changes. And update affected cases.

Issue: #


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

This PR update gpuweb/types version to include immediate related changes.
And update affected cases.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the @webgpu/types package from version 0.1.66 to 0.1.67 to include support for the WebGPU "immediates" feature. The changes add the maxImmediateSize limit and integrate the setImmediates method across various encoder types in the validation test suite.

  • Updates @webgpu/types dependency to version 0.1.67
  • Adds maxImmediateSize limit to capability information with default values (64 for core, 0 for compatibility)
  • Extends encoder open state validation tests to include setImmediates method for all applicable encoder types

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
package.json Updates @webgpu/types version from 0.1.66 to 0.1.67
package-lock.json Updates lock file with new @webgpu/types version and integrity hash
src/webgpu/capability_info.ts Adds maxImmediateSize limit with values 64 (core) and 0 (compatibility)
src/webgpu/api/validation/encoding/encoder_open_state.spec.ts Adds setImmediates to command info objects and test implementations for GPURenderPassEncoder, GPURenderBundleEncoder, and GPUComputePassEncoder

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@shaoboyan091
Copy link
Contributor Author

Canary seems crashed today. I'd like to check the change with canary and then merge it.

@shaoboyan091 shaoboyan091 merged commit eca60d9 into gpuweb:main Dec 5, 2025
1 check passed
greggman added a commit that referenced this pull request Dec 9, 2025
kainino0x pushed a commit that referenced this pull request Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants