-
Notifications
You must be signed in to change notification settings - Fork 100
Rollin Immediates #4517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollin Immediates #4517
Conversation
This PR update gpuweb/types version to include immediate related changes. And update affected cases.
79cd872 to
0ccf8e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the @webgpu/types package from version 0.1.66 to 0.1.67 to include support for the WebGPU "immediates" feature. The changes add the maxImmediateSize limit and integrate the setImmediates method across various encoder types in the validation test suite.
- Updates @webgpu/types dependency to version 0.1.67
- Adds maxImmediateSize limit to capability information with default values (64 for core, 0 for compatibility)
- Extends encoder open state validation tests to include setImmediates method for all applicable encoder types
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updates @webgpu/types version from 0.1.66 to 0.1.67 |
| package-lock.json | Updates lock file with new @webgpu/types version and integrity hash |
| src/webgpu/capability_info.ts | Adds maxImmediateSize limit with values 64 (core) and 0 (compatibility) |
| src/webgpu/api/validation/encoding/encoder_open_state.spec.ts | Adds setImmediates to command info objects and test implementations for GPURenderPassEncoder, GPURenderBundleEncoder, and GPUComputePassEncoder |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Canary seems crashed today. I'd like to check the change with canary and then merge it. |
This PR update gpuweb/types version to include immediate related changes. And update affected cases.
Issue: #
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.