-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disentangle tests #1076 #1104
Disentangle tests #1076 #1104
Conversation
Tox fails with exception that it cannot find valid OPENAI_API_KEY, though I've tried adding it in the ci.yaml name: Run tox There is a secret called OPENAI_API_KEY Do you have an idea what could be going wrong here @ErikBjare ? I saw that you have a rather advanced setup including a key in https://github.com/ErikBjare/gptme/blob/master/.github/workflows/bot.yml |
@ATheorell I figured it must be a quirk of tox, and I found this: https://tox.wiki/en/latest/config.html#passenv So we need to set |
@ATheorell Took the liberty, we'll see if it works... Edit: looks like that did it! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1104 +/- ##
==========================================
- Coverage 84.33% 75.79% -8.54%
==========================================
Files 27 27
Lines 1564 1566 +2
==========================================
- Hits 1319 1187 -132
- Misses 245 379 +134 ☔ View full report in Codecov by Sentry. |
As stated in #1076 the tests are way too tangled. In particular, usage of cached chatgpt responses in the tests have led to that most small changes have lead to multiple failing tests. This has been particularly challenging for new contributors.
In this PR: