Upgraded for grails 7 #47
Conversation
sbglasius
left a comment
sbglasius
left a comment
There was a problem hiding this comment.
Thank you. Please look over my comments
build.gradle
Outdated
| compile 'org.xhtmlrenderer:flying-saucer-pdf-openpdf:9.1.22' | ||
| testCompile("org.apache.pdfbox:pdfbox:1.0.0") { | ||
| implementation 'org.xhtmlrenderer:flying-saucer-pdf-openpdf:9.1.22' | ||
| testImplementation("org.apache.pdfbox:pdfbox:1.0.0") { |
There was a problem hiding this comment.
I think this should be upgraded to the latest https://mvnrepository.com/artifact/org.apache.pdfbox/pdfbox/3.0.5
build.gradle
Outdated
| apply plugin: 'eclipse' | ||
| apply plugin: 'idea' |
There was a problem hiding this comment.
Both plugins are not needed, as they both understand Gradle out of the box
There was a problem hiding this comment.
Hmmm... I copied from the generated build.gradle file when running create-plugin. Should a ticket be raised in grails-core to remove that if its not needed?
There was a problem hiding this comment.
Consider using github workflows instead. See https://github.com/grails-plugins/grails-mail/tree/5.0.x/.github for examples
src/test/groovy/grails/plugins/rendering/datauri/DataUriSpec.groovy
Outdated
Show resolved
Hide resolved
|
|
||
| import org.apache.commons.codec.binary.Base64 | ||
|
|
||
| class DataUri { |
There was a problem hiding this comment.
Consider making @CompileStatic
grails-app/taglib/grails/plugins/rendering/RenderingTagLib.groovy
Outdated
Show resolved
Hide resolved
|
Thank you for putting in the effort @billgonemad |
|
Awesome thank you @sbglasius! |
|
@billgonemad you should be able to test the 7.0.0-RC1 version Check docs for dependencies: https://gpc.github.io/rendering/7.0.x/ |
|
@billgonemad and when you confirm that it's working for you, I'll make a 7.0.0 release 🙂 when Grails 7.0.0 goes GA that is 😉 |
|
@sbglasius Thank you! So far it appears to be workig for me, though we only really use the PDF functionality in our app. |
2 participants
No description provided.