Skip to content

Fixing not wiring beans in test #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graemerocher merged 3 commits into from
Apr 22, 2016
Merged

Fixing not wiring beans in test #32

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
05bba2f
#31 services are not required
magx2 Apr 22, 2016
7f7276b
#31 pulling common code into method
magx2 Apr 22, 2016
580a4b6
#31 adding null check
magx2 Apr 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 15 additions & 18 deletions src/main/groovy/grails/plugins/rendering/RenderingTrait.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,43 +29,40 @@ import org.springframework.beans.factory.annotation.Autowired
@Enhances("Controller")
trait RenderingTrait extends ServletAttributes{

@Autowired
@Autowired(required = false)
PdfRenderingService pdfRenderingService

@Autowired
@Autowired(required = false)
GifRenderingService gifRenderingService

@Autowired
@Autowired(required = false)
JpegRenderingService jpegRenderingService

@Autowired
@Autowired(required = false)
PngRenderingService pngRenderingService

boolean renderPdf(Map args) {
def adjustedArgs = [controller: this]
adjustedArgs.putAll args
pdfRenderingService.render(adjustedArgs, response)
render pdfRenderingService, args
}

boolean renderGif(Map args) {
def adjustedArgs = [controller: this]
adjustedArgs.putAll args

gifRenderingService.render(adjustedArgs, response)
render gifRenderingService, args
}

boolean renderJpeg(Map args) {
def adjustedArgs = [controller: this]
adjustedArgs.putAll args

jpegRenderingService.render(adjustedArgs, response)
render jpegRenderingService, args
}

boolean renderPng(Map args) {
render pngRenderingService, args
}

private boolean render(RenderingService renderService, Map args) {
if(!renderService) throw new IllegalStateException("Bean with rendering service was not injected!")

def adjustedArgs = [controller: this]
adjustedArgs.putAll args

pngRenderingService.render(adjustedArgs, response)
}

renderService.render(adjustedArgs, response)
}
}