Skip to content

fix: format week number with numerals #2756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: format week number with numerals #2756

wants to merge 2 commits into from

Conversation

gpbl
Copy link
Owner

@gpbl gpbl commented May 4, 2025

This PR fixes the week numbers not being properly formatted when using the numerals prop:

Screen Shot 2025-05-04 at 14 59 25

  • Updated formatWeekNumber to use DateLib and formatNumber
  • Added more tests

Result:

Screen Shot 2025-05-04 at 14 59 53

gpbl added 2 commits May 4, 2025 14:45
@gpbl
fix: week numbers not formatted by numerals
48c7869 
Signed-off-by: gpbl <io@gpbl.dev>
@gpbl
Add test
ad855bc 
Signed-off-by: gpbl <io@gpbl.dev>
@gpbl gpbl requested a review from rodgobbi May 4, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodgobbi rodgobbi Awaiting requested review from rodgobbi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gpbl