fix: add timezone to Date props
#2750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gpbl <io@gpbl.dev>
Signed-off-by: gpbl <io@gpbl.dev>
gpbl
changed the title
DateDate props
Signed-off-by: gpbl <io@gpbl.dev>
rodgobbi
approved these changes
Apr 27, 2025
gpbl
referenced
this pull request
Apr 27, 2025
When initialMonth is passed as Date type, it would override the provided timezone settings. This fix ensures proper timezone handling.
|
Thanks @rodgobbi ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2658, we fixed the
initialMonthprop to account the timezone when using aDateobject to set the initial month. In this PR, I am applying the same fix to other props that rely onDate.Relevant comment about tests failing due to timezone overrides:
814cb76#commitcomment-155917971