Cannot read property 'focus' of undefined in DayPicker

[speicus]

Steps to reproduce:

1. Open https://codesandbox.io/s/23vz0vrn7r
2. DayPicker will display December, 2018
3. Click on January 5, 2019 (with is also displayed because of showOutsideDays is true).
4. Press left cursor key.

Result: An arrow is thrown: "Cannot read property 'focus' of undefined"
Expected result: the focus moves from January 5 to January 4.

[gpbl]

Thanks for the report!

[gpbl]

So this is a special case when the "outside" day falls out of the toMonth/fromMonth months. I'm thinking maybe we should just hide the day (i.e. not displaying it at all)?

[gpbl]

This would be the result:

[lohmatiy-lapa]

This behaviour can be reproduced without fromMonth/toMonth options. toMonth option is used in the example only to easily reproduce focus on the outside day. But outside day may got focus also by mouse button down event on day, then move mouse outside the day-picker component to any area without focus holding the button and then release the mouse button. But this is hard to describe, so in the example used toMonth to prevent month change to be able focus on day just by click event on it. There is gif with reproduce without using toMonth:

By the way the same error could be reproduced for outside day before current month also by focus on it and press left cursor button:

Also there is strange behaviour when focusing outside day after month and then pressing right cursor button:

So the real reason of the issue is still exists. And also I think that hiding outside days in the border cases is not clear solution.

[speicus]

Basically, what @lohmatiy-lapa said. The issue is still there, and from what I understand, can be fixed by modifying this line: https://github.com/gpbl/react-day-picker/blob/master/src/DayPicker.js#L305

There's actually a lot of places in DayPicker.js where dayNodes is accessed by index without checking if that index exists. @gpbl, please consider reopening this — I believe this can be easily fixed by adding additional checks.

[speicus]

As to hiding the days which fall out from toMonth / fromMonth — I think it’s a great idea.