Add __BSD_VISIBLE define

[valpackett]

Some projects including this as a simple file dependency might have e.g. _ANSI_SOURCE defined in the compiler args, which unsets __BSD_VISIBLE, which hides the u_int type on FreeBSD.

[gpakosz]

Hello @unrelentingtech 👋

I'm not sure I understand the need for such a change: what doesn't compile in whereami.c exactly when __BSD_VISIBLE is not defined?

[valpackett]

The u_int type is undefined, which is used in a cast for a sysctl argument.

__BSD_VISIBLE becomes defined to 0, hiding this type, when things like _XOPEN_SOURCE are enabled by the build system, as was the case with Darktable's inclusion of whereami.

[gpakosz]

Maybe it's a better idea to use unsigned int instead of u_int for that single cast?

[valpackett]

Maybe. I guess u_int is better from the "strict adherence to the manpage" standpoint but why not do the practical thing…

[gpakosz]

Or

    if (sysctl(mib, 4, path, &size, NULL, 0) != 0)
        break;

In any case, force defining __BSD_VISIBLE back, while it's a system header thing, seems wrong to me.

[gpakosz]

I committed the latest suggestion. Thanks for the report!