Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DFC-207]: Amend base files in line with govuk-frontend v5 changes #415

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Joanneyoung01
Copy link
Contributor

@Joanneyoung01 Joanneyoung01 commented Sep 26, 2024

Proposed changes

Update base files to reflect the changes as outlined on the GOVUK frontend version 5 documentation.

  • Remove initAll functions as this is not initialised within the node modules.
  • Declare script type as module, as version 5 now uses ES6 modules.

What changed

Base files + Unrecoverable error page

Why did it change

GOVUK version 5 updates

Please refer to guidance which outlines why the changes have been applied.
https://govukverify.atlassian.net/wiki/spaces/DIFC/pages/4523851778/V5+Upgrade+Guidance+for+the+One-Login+Programme

This has been tested locally using the Driving Licence repository.
No console errors shown.

@Joanneyoung01 Joanneyoung01 requested review from a team as code owners September 26, 2024 15:52
Copy link

sonarcloud bot commented Sep 30, 2024

@di-aholme di-aholme marked this pull request as draft October 1, 2024 15:57
@di-aholme
Copy link
Contributor

Converted to a draft until the v5 upgrade is ready to be rolled out across the programme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants