[KIWI-1951]- BAV | BE | Handle Response from Experian Crosscore BAV #248
Conversation
GDainton
changed the title
|
src/VerifyAccountHandler.ts
Outdated
| return await VerifyAccountRequestProcessor.getInstance(logger, metrics, VENDOR_TOKEN).processHmrcRequest(sessionId, body, clientIpAddress, encodedHeader); | ||
| } else { | ||
| const experianTokenSsmPath = checkEnvironmentVariable(EnvironmentVariables.EXPERIAN_TOKEN_SSM_PATH, logger); | ||
| VENDOR_TOKEN = await getParameter(experianTokenSsmPath); |
There was a problem hiding this comment.
Will this be replaced by the token table?
There was a problem hiding this comment.
I'll check with Stelios
src/services/ExperianService.ts
Outdated
| const params = { | ||
| header: { | ||
| tenantId: uuid, | ||
| requestType: "BAVConsumer-Standard", |
There was a problem hiding this comment.
Can we move "BAVConsumer-Standard" to a variable so its understood this is a product name
There was a problem hiding this comment.
Do you mean set it in Constants? Like static readonly EXPERIAN_PRODUCT_NAME = "BAVConsumer-Standard"
| extensions: { | ||
| evidence: [ | ||
| { | ||
| txn: vendorUuid, |
There was a problem hiding this comment.
The txn value should be the third party request identifier. Can we confirm the value for this with Sanka
There was a problem hiding this comment.
Sure I will check with him tomorrow
There was a problem hiding this comment.
Waiting for Experian to supply their expRequestId to be used as txn property - shall we just retain this random UUID as a placeholder to avoid this PR being blocked @Stelios-CB
…rent credential vendor
What changed
The way that the code handles responses from the new credential vendor Experian
Why did it change
As Experian works slightly differently to HMRC the response has to be handled differently
Issue tracking
Environment variables or secrets