-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AUT-3823: Implement call to MFA reset authorize API to redirect to IPV Core #2245
Open
alhcomer
wants to merge
10
commits into
main
Choose a base branch
from
AUT-3823/ipv-redirect
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alhcomer
force-pushed
the
AUT-3823/ipv-redirect
branch
6 times, most recently
from
October 28, 2024 14:08
c0ebdb1
to
af6a8de
Compare
alhcomer
changed the title
AUT-3823: Add MFA reset with IPV journey feature switch
AUT-3823: Implement call to MFA reset authorize API to redirect to IPV Core
Oct 28, 2024
alhcomer
force-pushed
the
AUT-3823/ipv-redirect
branch
7 times, most recently
from
October 29, 2024 08:57
454be10
to
e522eac
Compare
ethanmills
reviewed
Oct 29, 2024
alhcomer
force-pushed
the
AUT-3823/ipv-redirect
branch
from
October 29, 2024 11:28
e522eac
to
f2aaf18
Compare
alhcomer
force-pushed
the
AUT-3823/ipv-redirect
branch
from
October 30, 2024 10:24
b726933
to
c519072
Compare
ethanmills
reviewed
Oct 30, 2024
src/components/enter-authenticator-app-code/index-2fa-service-uplift-auth-app.njk
Show resolved
Hide resolved
alhcomer
force-pushed
the
AUT-3823/ipv-redirect
branch
2 times, most recently
from
November 15, 2024 11:10
551f3e5
to
308ce57
Compare
alhcomer
force-pushed
the
AUT-3823/ipv-redirect
branch
from
November 15, 2024 11:20
308ce57
to
ae9459a
Compare
- Created a service to call the MfaResetAuthorizeHandler, sending the email of the user who wants to change their MFA method in the body. - This handler builds and signs a URL that contains a signed JWT and storage token in the query string. - This URL will be used to redirect the user to IPV Core to go through the identity verification journey. - Calling this service will be implemented in its own controller, which will be called when the user clicks 'change your security codes'.
… to IPV when a user clicks 'change how you get security codes' - This controller calls the mfa_reset_authorize endpoint through the associated service. - If the request is successful, the controller returns a redirect to the returned IPV URL
… get security codes' - Goes to the mfa-reset-with-ipv controller if supportMfaResetWithIpv is true - Otherwise, goes to the check your email security codes screen (same journey as before this commit) - mfa-reset-with-ipv controller returns returns url to redirect to IPV core if API call is successful
…r mfa controller test
… get security codes' - Goes to the mfa-reset-with-ipv controller if supportMfaResetWithIpv is true - Otherwise, goes to the check your email security codes screen (same journey as before this commit) - mfa-reset-with-ipv controller returns returns url to redirect to IPV core if API call is successful
…actory function to be called
…le factory function to be called
alhcomer
force-pushed
the
AUT-3823/ipv-redirect
branch
from
November 15, 2024 14:19
ae9459a
to
6013151
Compare
Open
2 tasks
Quality Gate passedIssues Measures |
alhcomer
force-pushed
the
AUT-3823/ipv-redirect
branch
from
November 15, 2024 16:07
6013151
to
cd8d12f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Created a service to call the MfaResetAuthorizeHandler API in the backend. If the request is successful, the API returns a URL to redirect the user to IPV Core's prove identity journey. This service is called when the user clicks the "change how you get security codes" link on the enter mfa pages.
How to review
Checklist
Related PRs
govuk-one-login/authentication-api#5535