DontMerge - superseded UDP-48 #36
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkynt
force-pushed
the
feat/udp-48-post-cdk-tracing
branch
from
fb993b2 to
71b906e
Compare
darkynt
force-pushed
the
feat/udp-48-post-cdk-tracing
branch
from
71b906e to
ecfa6cc
Compare
darkynt
commented
Dec 23, 2025
| hooks: | ||
| - id: detect-secrets | ||
| args: ['--baseline', '.secrets.baseline'] | ||
| exclude: pnpm-lock.yaml |
Author
There was a problem hiding this comment.
not a fan of this but the interface seems to be a string instead of an array/list
darkynt
commented
Dec 23, 2025
| "build:affected": "npx nx affected --target=build", | ||
| "lint:all": "npx nx run-many --target=lint", | ||
| "lint:affected": "npx nx affected --target=lint", | ||
| "lint:affected": "npx nx affected --target=lint --outputStyle static", |
Author
There was a problem hiding this comment.
quick fix for hanging precommit hooks backgrounded process(
darkynt
changed the title
darkynt
force-pushed
the
feat/udp-48-post-cdk-tracing
branch
from
6a817c5 to
fc47671
Compare
darkynt
force-pushed
the
feat/udp-48-post-cdk-tracing
branch
from
fc47671 to
5808dce
Compare
cdk/project.json
Outdated
| "executor": "nx:run-commands", | ||
| "options": { | ||
| "command": "npx cdk bootstrap", | ||
| "command": "DEVELOPER_ID=$(./scripts/set-developer.sh --value) npx cdk bootstrap", |
Contributor
There was a problem hiding this comment.
We can revert this so all cdk is bootstapped to the same s3
project.json
Outdated
| "cwd": "." | ||
| }, | ||
| "cache": true | ||
| }, |
Contributor
There was a problem hiding this comment.
this has been removed as it was TF related
Author
There was a problem hiding this comment.
Good spot, no idea what merge-hell kept it here O_o
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.