Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add expected result and update number of ministries (Denmark) #441

Merged
merged 2 commits into from
Nov 3, 2024
Merged

Add expected result and update number of ministries (Denmark) #441

merged 2 commits into from
Nov 3, 2024

Conversation

RVA2869
Copy link
Collaborator

@RVA2869 RVA2869 commented Nov 3, 2024

Description

Issue Reference

Fixes #(issue)

PR Details

1 ministry too many.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Code refactor

Checklist

Please ensure the following before submitting the PR:

  • I have tested the changes locally, and they work as expected.
  • The code follows the project's coding standards and conventions.
  • Any query changes have been verified and are working correctly.
  • I have updated relevant documentation (if needed).
  • I have added unit tests or performed manual testing where necessary.

Screenshots (applicable to user interface changes)

@RVA2869 RVA2869 requested a review from Ainali November 3, 2024 16:04
@RVA2869 @Ainali
Update queries/generators/denmark.rq
b95497c 
Co-authored-by: Jan Ainali <ainali.jan@gmail.com>
Ainali
Ainali approved these changes Nov 3, 2024
View reviewed changes
Copy link
Member

@Ainali Ainali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Ainali Ainali merged commit a722d08 into govdirectory:main Nov 3, 2024
1 check passed
@RVA2869 RVA2869 deleted the denmark branch November 5, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ainali Ainali Ainali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RVA2869 @Ainali