Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

❌ Less Twitter more X #400

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Conversation

RVA2869
Copy link
Collaborator

@RVA2869 RVA2869 commented Jun 19, 2024

I'll leave it in draft until this question is resolved.

#294

@Ainali
Copy link
Member

Ainali commented Jun 20, 2024

Thanks for getting this moved along! It would be nice if we had some provenance of the image so that we know that it is aligned with our license. Do you think you could add that?

@RVA2869
Copy link
Collaborator Author

RVA2869 commented Jun 20, 2024

Thanks for getting this moved along! It would be nice if we had some provenance of the image so that we know that it is aligned with our license. Do you think you could add that?

It is the official X of x.com (Brand toolkit). With a black circle (homemade)
I haven't found anything about how to use or not use the logo.

@Ainali
Copy link
Member

Ainali commented Jun 21, 2024

Okay, on Commons it has been deemed to be too simple to be copyrightable: https://commons.wikimedia.org/wiki/File:X_logo_2023.svg

@Ainali
Copy link
Member

Ainali commented Jun 21, 2024

I would say that this PR would solve #294 for now. If we want to make another change later, we can create a new more specified issue later or reopen it.

@Abbe98
Copy link
Member

Abbe98 commented Jun 21, 2024

Given that Twitter has been renamed X on Wikidata I think we should follow and merge this.

Copy link
Member

@Ainali Ainali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@RVA2869 RVA2869 marked this pull request as ready for review June 21, 2024 18:21
@Ainali Ainali requested a review from Abbe98 June 22, 2024 09:55
@Abbe98 Abbe98 merged commit bcfcbc7 into govdirectory:main Jun 28, 2024
1 check passed
@RVA2869 RVA2869 deleted the less-twitter-more-x branch June 28, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants