Regression fix: allow multiple docker projects of the same govcms project at the same time #125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the
container_namein thedocker-compose.ymlfor the serviceclinot being dynamic (or absent which infers it being dynamic automatically), if i run two two of the same govcms projects with the same name, I get a naming conflict.Preferred solution: use
additional_contextsto container depending locally on each other.@see https://docs.docker.com/compose/how-tos/dependent-images/#use-another-services-image-as-the-base-image
Quick fix solution (this PR):
-> Remove
container_name(so its dynamic)-> Set image name to be dynamic so other dependancies so the new image name built. (not preferred because
docker compose build --pullbreaks.