Skip to content

Conversation

@barbun
Copy link

@barbun barbun commented Nov 29, 2024

Issue

The scaffold ships with two container definitions that increase the start time of the docker compose stack. These are used only by a handful of customers. To reduce the pipeline consumption usage by projects, we should make these opt-in only.

Proposed solution

Comment out the services and adjust the build commands.

@steveworley steveworley requested a review from Copilot April 8, 2025 02:40
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

docker-compose.yml:138

  • The instructions in the commented out block imply that both test and chrome services should be enabled together. Please add guidance or a note indicating that uncommenting only one of these may lead to dependency issues since the chrome service depends on the test service.
# Uncomment to enable testing.

.ahoy.yml:9

  • Switching the wait command from the 'test' container to the 'cli' container is a critical change. Please verify that the cli container is properly configured and ready to handle this waiting logic, ensuring it truly replaces the original behavior.
docker compose exec -T cli dockerize -wait tcp://mariadb:3306 -timeout 2m &&

.ahoy.yml:29

  • Ensure that using the 'cli' container in place of the removed 'test' service does not negatively affect the expected timing or initialization dependencies in your pipeline.
docker compose exec -T cli dockerize -wait tcp://mariadb:3306 -timeout 2m &&

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants