fix(api): preserve modified date in R2 progression#2352
Merged
gotson merged 1 commit intoJul 20, 2026
Conversation
ReadProgressDao converts READ_DATE from UTC to the server local time when loading a progression. R2Progression then passed that local value to toZonedDateTime(), which treats it as UTC and shifts the returned modified instant by the server local UTC offset. Use toUTCZoned() so GET /progression preserves the instant submitted by the client. This fixes incorrect modified timestamps in non-UTC server timezones without changing stored READ_DATE values.
Owner
|
thanks! |
gotson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReadProgressDao converts READ_DATE from UTC to the server local time when loading a progression. R2Progression then passed that local value to toZonedDateTime(), which treats it as UTC and shifts the returned modified instant by the server local UTC offset.
Use toUTCZoned() so GET /progression preserves the instant submitted by the client. This fixes incorrect modified timestamps in non-UTC server timezones without changing stored READ_DATE values.