feat: secrets and volumes as secrets #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this hall handle all the secrets to be passed as env variables to firehose - this shall handle secret credentials and creating volumes and mounts
ishanarya0
force-pushed
the
secrets-volume
branch
3 times, most recently
from
eb2910f to
e173000
Compare
ishanarya0
force-pushed
the
secrets-volume
branch
from
e173000 to
272a740
Compare
ishanarya0
commented
Jul 3, 2023
spy16
reviewed
Jul 3, 2023
spy16
reviewed
Jul 11, 2023
spy16
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firehose chart to read from secrets