Skip to content

feat(app): add custom labels #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2023

Conversation

feminovia
Copy link

@feminovia feminovia commented May 5, 2023

This PR should allow addition of deployment labels from values.yaml.

@mabdh
Copy link
Member

mabdh commented May 8, 2023

@feminovia we need to bump up the version in Chart.yml to 0.5.1

@mabdh mabdh self-requested a review May 8, 2023 06:05
Copy link
Member

@mabdh mabdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@feminovia Please add the labels in template metadata labels too.

@feminovia feminovia force-pushed the add-custom-labels-app-template branch from f109caf to 48c196d Compare May 8, 2023 08:07
@mabdh mabdh self-requested a review May 8, 2023 08:09
@mabdh mabdh merged commit db60191 into goto:main May 8, 2023
@feminovia feminovia deleted the add-custom-labels-app-template branch May 8, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants