Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for go: download go1.23 toolchain not available #957

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

gabriel-vasile
Copy link
Contributor

The problem appears when trying to run locally:

➜  gotenberg git:(main) ✗ go run cmd/gotenberg/main.go
go: downloading go1.23 (darwin/arm64)
go: download go1.23 for darwin/arm64: toolchain not available

The change is based on this answer: golang/go#62278 (comment)

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.34%. Comparing base (da8eeb5) to head (cff11c7).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #957   +/-   ##
=======================================
  Coverage   92.34%   92.34%           
=======================================
  Files          46       46           
  Lines        4194     4194           
=======================================
  Hits         3873     3873           
  Misses        225      225           
  Partials       96       96           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gulien
Copy link
Collaborator

gulien commented Sep 5, 2024

TIL 😄 thanks for your PR!

@gulien gulien merged commit 03ced23 into gotenberg:main Sep 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants