Added: warning when duplicate keys cause tests to be overwritten #843
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make test-all
(UNIX) passes. CI will also test thisDescription of change
Prints out warning messages when overlapping keys are detected, for example:
goss.yaml:
goss_embed.yaml:
Same with render:
This warning is printed for both failing and passing tests, essentially it is informing the user that the tests were overwritten.. which may or may not be desired.
As a consequence of this change, I moved some existing log levels around to match what I would expect as a user:
TRACE
- Detailed internal system activities useful for goss developers to debug.DEBUG
- Information useful for the goss user to debug.INFO
- General operational messages, useful for tasks where a more structured output is needed (e.g.goss serve
).WARN
- Non-critical issues that may require attention, such as overwritten keys or deprecated features.closes #743
Questions
-l warn
or-l error