-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename binaries to strip '-alpha' #671
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -408,14 +408,14 @@ func addAlphaFlagIfNeeded(app *cli.App) { | |
if runtime.GOOS == "darwin" || runtime.GOOS == "windows" { | ||
app.Flags = append(app.Flags, cli.StringFlag{ | ||
Name: "use-alpha", | ||
Usage: fmt.Sprintf("goss is alpha-quality. Set to 1 to use anyway."), | ||
Usage: fmt.Sprintf("goss on macOS/Windows is alpha-quality. Set to 1 to use anyway."), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Even though this message should never display on other platforms, I figured this more clearly set expectations. |
||
EnvVar: "GOSS_USE_ALPHA", | ||
Value: "0", | ||
}) | ||
} | ||
} | ||
|
||
const msgFormat string = `WARNING: goss for this platform (%q) is alpha-quality, work-in-progress, and not yet exercised within continuous integration. | ||
const msgFormat string = `WARNING: goss for this platform (%q) is alpha-quality, work-in-progress and community-supported. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I figured that the integration tests running in CI merited this rewording. |
||
You should not expect everything to work. Treat linux as the canonical behaviour to expect. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could equally have called this
test-int-all-commands-%
and similarlyrun-command-tests.sh
but I thought that might have been confusing with thecommand
assertion specifically; what do you think, @aelsabbahy?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no opinion on this currently.
I have some plans to re-write all of the integration tests.. but want to wait until after
v4