Account for multiple colon's in dns key (IPv6 PTR) #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at qtype matches A-Z
|
Looks good. I'll look into reverting the disabled tests. |
petemounce
pushed a commit
to improbable-eng/goss
that referenced
this pull request
Aug 30, 2019
# By Ahmed Elsabbahy (4) and others # Via Ahmed Elsabbahy * upstream/master: Migrate from dep to go modules. (goss-org#437) Fix systemd service implementation to not fallback to sysv (goss-org#319) (goss-org#374) Fix TCP/DNS examples in the manual (goss-org#429) Handle invalid CLI flags (goss-org#421) Add "dcgoss flavour" of dgoss (goss-org#427) Use most recent docker files Revert "Disable dnstest (goss-org#440)" Account for multiple colon's in dns key (IPv6 PTR) and naive check that qtype matches A-Z (goss-org#441) fix(test): Remove mtu check due to travis changes Add new options to Command resource (goss-org#434) Disable dnstest (goss-org#440) # Conflicts: # .travis.yml # docs/manual.md # integration-tests/test.sh
BenjaminHerbert
pushed a commit
to BenjaminHerbert/goss
that referenced
this pull request
May 28, 2020
…at qtype matches A-Z (goss-org#441)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #428 and adds a very naive check that the type part of a key is an uppercase string.
Fixed the dnstest.io NSD servers. some cron tasks had been silently failing when re-signing records 🤷♂