Allow setting of Source IP for Addr Test #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelsabbahy
requested changes
May 20, 2018
resource/addr.go
Outdated
| Title string `json:"title,omitempty" yaml:"title,omitempty"` | ||
| Meta meta `json:"meta,omitempty" yaml:"meta,omitempty"` | ||
| Address string `json:"-" yaml:"-"` | ||
| LocalAddress string `json:"localaddress" yaml:"localaddress"` |
There was a problem hiding this comment.
Should have an "omitempty" for this.
This Change allows the Source IP with which the Addr test is run to be set.
|
I had that fix locally already, never committed. And rebased to the master version. Hope this is ok now, i actually really have no clue about programming go :P |
aelsabbahy
approved these changes
Dec 6, 2019
BenjaminHerbert
pushed a commit
to BenjaminHerbert/goss
that referenced
this pull request
May 28, 2020
* Allow setting of Source IP for Addr Test This Change allows the Source IP with which the Addr test is run to be set. * Gofmt the code and add tests * More gofmt fixes * Rename localaddress -> local-address
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Change allows the Source IP with which the Addr test is run to be
set.