Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
Shippo::Shipment.rates('<shipment_object_id>')
would result in the following error:This would just normally mean there are no rates for that shipment.
However,
is not the correct endpoint.
This PR adds a param for the shipment object ID and interpolates it into the url, resulting in the endpoint with correct params: https://api.goshippo.com/shipments/<shipment_object_id>/rates
With these changes it can be called without error like so:
Shippo::Shipment.rates('<shipment_object_id>')
orShippo::Shipment.rates('<shipment_object_id>', '<currency_code>')