Skip to content

feat(ENGKNOW-2942): Add user name to creds service call. #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gmagnu merged 2 commits into from
Dec 3, 2025
Merged

feat(ENGKNOW-2942): Add user name to creds service call. #83

gmagnu merged 2 commits into from
Dec 3, 2025

Conversation

@gmagnu
Copy link
Contributor

@gmagnu gmagnu commented Dec 3, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 3, 2025 •
edited
Loading

Junit Tests - Summary

4 351 tests  +1   4 185 ✅ +1   10m 42s ⏱️ + 1m 14s
  457 suites ±0     166 💤 ±0 
  457 files   ±0       0 ❌ ±0 

Results for commit 93f7123. ± Comparison against base commit 60599af.

This pull request removes 2 and adds 3 tests. Note that renamed tests count towards both. 
org.gorpipe.security.cred.UTestCredentialsHelperMain ‑ testForUserOption
org.gorpipe.security.cred.UTestCredentialsHelperMain ‑ testInvalidForUserOption

org.gorpipe.security.cred.UTestCredentialsHelperMain ‑ testForUserIdOption
org.gorpipe.security.cred.UTestCredentialsHelperMain ‑ testForUserNameOption
org.gorpipe.security.cred.UTestCredentialsHelperMain ‑ testInvalidForUserIdOption

♻️ This comment has been updated with latest results.

lakshmiprabhaseker
lakshmiprabhaseker approved these changes Dec 3, 2025
View reviewed changes
Copy link

@lakshmiprabhaseker lakshmiprabhaseker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmagnu gmagnu merged commit e8accc3 into main Dec 3, 2025
11 checks passed
@gmagnu gmagnu deleted the ENGKNOW-2942-gor-use-preferred-username-for-credentials branch December 3, 2025 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lakshmiprabhaseker lakshmiprabhaseker lakshmiprabhaseker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gmagnu @lakshmiprabhaseker