fix(ENGKNOW-2746): gor services resolve stale file handle issue

model/src/main/java/org/gorpipe/gor/driver/adapters/StreamSourceSeekableFile.java

@@ -81,29 +81,14 @@ public int read(byte[] b, int off, int len) throws IOException {
             // Safe to cast because length-position can only be less than len.
             len = (int) (length() - position);
         }
-        // Individual operations are retried automatically with our retry wrapper, but we
-        // may get errors, such as stale file handle, that we can recover from by
-        // reopening the file before attempting the read operation again.
-        int numRetries = 0;
-        while (true) {
-            try (InputStream stream = source.open(position, len)) {
-                int read = StreamUtils.readToBuffer(stream, b, off, len);
-                if (read > 0) {
-                    position += read;
-                }
-                log.trace("Actually read: {}", read);
-                return read;
-            } catch (IOException e) {
-                if (e.getMessage().equals("Stale file handle")) {
-                    numRetries++;
-                    if (numRetries >= 3) {
-                        log.warn("Stale file handle on {} after {} retries", getMeta().getNamedUrl(), numRetries, e);
-                        throw(e);
-                    }
-                } else {
-                    throw(e);
-                }
+
+        try (InputStream stream = source.open(position, len)) {
+            int read = StreamUtils.readToBuffer(stream, b, off, len);
+            if (read > 0) {
+                position += read;
             }
+            log.trace("Actually read: {}", read);
+            return read;
         }
     }
 

model/src/main/java/org/gorpipe/gor/driver/providers/stream/sources/wrappers/RetryStreamSourceWrapper.java

@@ -190,8 +190,12 @@ public long skip(long n) throws IOException {
          * NB: If reopening the stream fails - it is not retried.
          */
         private void reopen() {
+            // Close the current stream
             StreamUtils.tryClose(in);
-            // Need to open it using the outer super class open (and be careful NOT to warp it again)
+            // Close the underlying source stream (to clear any cached state)
+            RetryStreamSourceWrapper.super.close();
+
+            // Need to open it using the outer super class open (and be careful NOT to wrap it again)
             if (length == null) {
                 in = RetryStreamSourceWrapper.super.open(start + getPosition());
             } else {

model/src/main/java/org/gorpipe/gor/driver/providers/stream/sources/wrappers/WrappedDataSource.java

@@ -74,6 +74,11 @@ public void close() {
         wrapped.close();
     }
 
+    @Override
+    public void validateAccess() {
+        wrapped.validateAccess();
+    }
+
     @Override
     public boolean exists() {
         return wrapped.exists();