Skip to content

Conversation

ghost
Copy link

@ghost ghost commented May 26, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • [x ] Bug Fix
  • Optimization
  • Documentation Update
  • Go Version Update
  • Dependency Update

Description

Fix test broken by #908.

Related Tickets & Documents

  • Related Issue #
  • Closes #

Added/updated tests?

  • [x ] Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

Run verifications and test

  • make verify is passing BROKEN by previous commit
  • [x ] make test is passing

@ghost
Copy link
Author

ghost commented May 26, 2024

I am looking more at the attempt to revert 666c197 and see other problems.

The project should reset to the version before coreydaly's first commit in this repo and cherry pick commits made after coreydaly's first commit. This may not be so bad because many of those commits fix bugs introduced by coreydaly.

Never mind. I am moving to the fork.

@ghost ghost closed this May 26, 2024
@FZambia FZambia mentioned this pull request Jun 9, 2024
1 task
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants