Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not handle network error in SetCloseHandler() #863

Merged
merged 4 commits into from
Jan 22, 2024
Merged

Do not handle network error in SetCloseHandler() #863

merged 4 commits into from
Jan 22, 2024

Commits on Jan 22, 2024

  1. Do not handle network error in SetCloseHandler() 

    The 666c197 added an error handling in `SetCloseHandler()` and peer
stops getting `CloseError` when network issue like `write: broken
pipe` happens because the close handle returns the error.

Hence this patch changes to skip network error handling.
    @nak3 @AlexVulaj
    nak3 authored and AlexVulaj committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    f0f3bf0 View commit details
    Browse the repository at this point in the history

  2. Do not return error in SetCloseHandler

    @nak3 @AlexVulaj
    nak3 authored and AlexVulaj committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    8e0711b View commit details
    Browse the repository at this point in the history

  3. Print log message

    @nak3 @AlexVulaj
    nak3 authored and AlexVulaj committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    731d7a3 View commit details
    Browse the repository at this point in the history

  4. Revert "Print log message" 

    This reverts commit 6db907c.
    @nak3 @AlexVulaj
    nak3 authored and AlexVulaj committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    42fd2c0 View commit details
    Browse the repository at this point in the history