-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go version, add tools for verification and testing #263
Conversation
@coreydaley I saw you're planning to get rid of CircleCI settings. But, I've got a different idea that could be great for this project. I've sent a Pull Request (#262 gorilla/securecookie#79) where I've switched CircleCI over to GitHub Actions. With this, we can still do all our old tests and even use the newest version of Go. It's like keeping the good stuff we had and making sure it works with any new Go versions too. If we just delete CircleCI and don't replace it with something like GitHub Actions, we might mess up our tests or have issues with the newest Go. But with GitHub Actions, we keep our testing strong and up-to-date, which is really good for our work here. I think my PR is a good move for the project. I hope you can take another look at it. Let me know if you've got any questions, okay? |
@catatsuy Thank you for the pull request, we are currently working on swapping out circleci for github actions as part of the project transition, starting with gorilla/mux#718 |
9d2716d
to
1767b70
Compare
Codecov Report
@@ Coverage Diff @@
## main #263 +/- ##
=======================================
Coverage ? 76.86%
=======================================
Files ? 4
Lines ? 268
Branches ? 0
=======================================
Hits ? 206
Misses ? 54
Partials ? 8 |
148980f
to
5493726
Compare
4ea2103
to
8ec7ceb
Compare
8ec7ceb
to
a33f96d
Compare
a33f96d
to
856585b
Compare
856585b
to
b306c1d
Compare
Fixes #
Summary of Changes