Return E_PARSE error when JSON can't be parsed #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An empty-body HTTP 200 OK response was returned to malformed requests because: - As JSON could not be parsed, res.Version was empty and `err` was being overwritten by E_INVALID_REQ. Solution: only check that if there was no parse error. - As JSON could not be parsed, red.Id was empty and writeServerResponse was considering it was a Notification request, so the response was discarded. Solution: if ID is empty, make sure we're not trying to write an E_PARSE error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An empty-body HTTP 200 OK response was returned to malformed requests
because:
errwasbeing overwritten by E_INVALID_REQ. Solution: only check that if there
was no parse error.
was considering it was a Notification request, so the response was
discarded. Solution: if ID is empty, make sure we're not trying to
write an E_PARSE error.