Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ITunes RSS Support #110

Closed
wants to merge 2 commits into from
Closed

Add ITunes RSS Support #110

wants to merge 2 commits into from

Conversation

jj-style
Copy link

@jj-style jj-style commented Apr 8, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Go Version Update
  • Dependency Update

Description

Add Feed and Item structs with XML bindings for ITunes RSS tags so ITunes specific RSS tags can be generated for feeds.

Related Tickets & Documents

Added/updated tests?

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

Run verifications and test

  • make verify is passing
  • make test is passing

@jaitaiwan
Copy link
Member

I'm cautious about adding vendor-specifics as it increases the amount of things the maintainer has to look after for future versions. I plan to come back around to this and determine: can these changes be kept as a superset of this library or do they need tight integrations like this?

@jaitaiwan
Copy link
Member

I've had a chat with the other maintainers, and they agree that this feature, while super appreciated with all the tests etc, is something that can exist external to this repo and supplement the existing feature set without requiring us to maintain a spec for a different vendor. Thank you so much for your contribution and sorry we couldn't accept it. If you decide to put your work in its own repo let us know and we can link out to your project for those who are looking for itunes support.

@jj-style
Copy link
Author

Thanks for your response yeah that makes sense good to keep this core library vendor agnostic and add those in around externally.

I am away at the moment but at some point will build something based off this / maintain a fork as I also wanted to include other tags for podcasting 2.0 and I agree I don't think here is the place for that!

Thanks again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] iTunes RSS extensions support
2 participants