Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check for nil link to avoid runtime panic #95 #103

Merged
merged 1 commit into from
Sep 22, 2023
Merged

fix: check for nil link to avoid runtime panic #95 #103

merged 1 commit into from
Sep 22, 2023

Conversation

meblum
Copy link
Contributor

@meblum meblum commented Sep 20, 2023

What type of PR is this? (check all applicable)

  • Bug Fix

Description

Check for nil link in feed to avoid runtime panic

Related Issue

Added/updated tests?

  • Yes

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #103 (39c090f) into main (8b1dc44) will increase coverage by 1.88%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
+ Coverage   79.18%   81.07%   +1.88%     
==========================================
  Files           5        5              
  Lines         269      280      +11     
==========================================
+ Hits          213      227      +14     
+ Misses         48       45       -3     
  Partials        8        8              
Files Changed Coverage Δ
atom.go 97.26% <100.00%> (+4.83%) ⬆️
rss.go 90.62% <100.00%> (+0.62%) ⬆️

@meblum
Copy link
Contributor Author

meblum commented Sep 21, 2023

@apoorvajagtap @coreydaley
Would you please be able to review? The pull request template instructs to add gorilla/pull-request-reviewers as a pull-request reviewer. However, setting reviewers seems to be restricted to maintainers only.

Thanks

@AlexVulaj
Copy link
Member

Thanks for taking care of this @meblum . All looks good to me.

@AlexVulaj AlexVulaj self-assigned this Sep 22, 2023
@AlexVulaj AlexVulaj merged commit 3bdeb10 into gorilla:main Sep 22, 2023
9 checks passed
Bios-Marcel pushed a commit to Bios-Marcel/feeds that referenced this pull request Apr 27, 2024
## What type of PR is this? (check all applicable)
- [x] Bug Fix

## Description
Check for nil link in feed to avoid runtime panic

## Related Issue
- Closes gorilla#95

## Added/updated tests?
- [x] Yes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[bug] slice bounds out of range [-1:]
2 participants