Compare token fix #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- subtle.ConstantTimeCompare did not check for matching slice lengths prior to Go 1.3 (fixed in https://codereview.appspot.com/118750043). - gorilla/csrf was released a year after this came into place. - Our TravisCI tests did not test against older versions of Go, and this wasn't caught as a result. - Have added Go 1.2 and Go 1.3 to the TravisCI config to address any future issues.
elithrar
added a commit
that referenced
this pull request
Feb 13, 2016
[bugfix] Compare token fix - subtle.ConstantTimeCompare did not check for matching slice lengths prior to Go 1.3 (fixed in https://codereview.appspot.com/118750043). - gorilla/csrf was released a year after this came into place. - Our TravisCI tests did not test against older versions of Go, and this wasn't caught as a result. - Have added Go 1.2 and Go 1.3 to the TravisCI config to address any future regressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also as per goji/csrf#8
1.3 (fixed in https://codereview.appspot.com/118750043).
caught as a result.
regressions.